Re: [PATCH 2/8] hwmon: (ibmpex) remove unnecessary OOM messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 29, 2014 at 05:07:58PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Looks ok, so you can add:
Acked-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

> ---
>  drivers/hwmon/ibmpex.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 20ab0fb..030e7ff 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -463,10 +463,8 @@ static void ibmpex_register_bmc(int iface, struct device *dev)
>  	int err;
>  
>  	data = kzalloc(sizeof(*data), GFP_KERNEL);
> -	if (!data) {
> -		dev_err(dev, "Insufficient memory for BMC interface.\n");
> +	if (!data)
>  		return;
> -	}
>  
>  	data->address.addr_type = IPMI_SYSTEM_INTERFACE_ADDR_TYPE;
>  	data->address.channel = IPMI_BMC_CHANNEL;
> -- 
> 1.7.10.4
> 
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux