Re: [PATCH 1/2] hwmon: vexpress: Use legal hwmon device names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/24/2014 01:34 AM, Pawel Moll wrote:
On Wed, 2014-04-23 at 19:16 +0100, Guenter Roeck wrote:
On Wed, Apr 23, 2014 at 06:27:04PM +0100, Pawel Moll wrote:
The driver used to directly us a DT 'compatible' property for
the 'name' attribute of the hwmon devices. Unfortunately it
contains '-' which is illegal in this context. It messes up
libsensors and thus every application using it.

Fixed by providing equivalent (and simpler) name strings.

Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Signed-off-by: Pawel Moll <pawel.moll@xxxxxxx>

Hi Pawel,

can you use hwmon_device_register_with_groups() to register
the hwmon device ?  This would take care of the name attribute.

I have a third patch doing exactly this (well, using devm_* version),
but it's not a fix, so I'll post it separately. The previous version of
it is here:


Ok, makes sense. Both patches applied and currently testing.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux