On Tue, Apr 22, 2014 at 04:32:58PM +0200, Jean Delvare wrote: > On Tue, 22 Apr 2014 04:26:41 -0700, Guenter Roeck wrote: > > Updating the hysteresis value when updating the critical temperature limit > > was following the rule of 'least surprise'. However, it had the undesirable > > side effect of changing the hysteresis for all other attributes, which > > defeats the purpose of least surprise. In addition, it could result in > > invalid hysteresis values if the resulting hysteresis was too large. In such > > cases the resulting hysteresis ended up changed anyway, which again defeats > > the purpose. So drop that code and document the new behavior. > > > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > --- > > v3: Replace documentation with text suggested by Jean > > Drop obsolete comment > > v2: Move this patch ahead of subsequent patches to simplify those > > > > Documentation/hwmon/lm77 | 20 ++++++++++++++++++-- > > drivers/hwmon/lm77.c | 6 ------ > > 2 files changed, 18 insertions(+), 8 deletions(-) > > (...) > > Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> > Thanks a lot for the reviews and your time! Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
