Re: [PATCH] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 5, 2014 at 1:20 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

> LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.
>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  drivers/hwmon/pmbus/ltc2978.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c
> index de3c152..7647c11 100644
> --- a/drivers/hwmon/pmbus/ltc2978.c
> +++ b/drivers/hwmon/pmbus/ltc2978.c
> @@ -54,6 +54,7 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883
> };
>  #define LTC3883_MFR_IIN_PEAK           0xe1
>
>  #define LTC2974_ID                     0x0212
> +#define LTC2974_ID_REV2                        0x0213
>

Hello Guenter,

only a nit-pik; since the other devices in this file have REVx appended,
should this device too?

thanks,

*** Rob.

 #define LTC2977_ID                     0x0130
>  #define LTC2978_ID_REV1                        0x0121
>  #define LTC2978_ID_REV2                        0x0122
> @@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
>         if (chip_id < 0)
>                 return chip_id;
>
> -       if (chip_id == LTC2974_ID) {
> +       if (chip_id == LTC2974_ID || chip_id == LTC2974_ID_REV2) {
>                 data->id = ltc2974;
>         } else if (chip_id == LTC2977_ID) {
>                 data->id = ltc2977;
> --
> 1.7.9.7
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@xxxxxxxxxxxxxx
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux