Hi Leandro, On 02/24/2014 02:14 PM, Leandro de Marco wrote:
Hi. First I would like to thank you in advance for your attention. The company I work for, is developing a HW that will use the ericson BMR456 Bus converter. Unfortunately, this chip is not listed on the lm-sensors list of devices supported. It is under my responsibility to make it work, and I was studying the pmbus kernel drivers and comparing the existing modules, as well as taking a look on their datasheet. I am an experienced C programmer, but new to the device driver world. I am having some doubts, and would like to ask for some help. I noticed that the pmbus generic driver has support for the BMR453/454 chip. Comparing these chips, I noticed that they seem to be very similar. At first, I saw that the BMR456/457 uses the direct data format for some PMBUS commands. Later I realized that such commands are not classified on any of the sensor classes (like PSC_VOLTAGE_OUT, PSC_CURRENT_OUT, etc) that are indexes in the direct, m, b and r fields of the pmbus_driver_info struct. Some of these PMBUS commands that uses the direct data format on the chip aren't even listed at pmbus.h. Anyway, I won't need those commands.
Which commands do you refer to ? Are those proprietary (mfg specific) commands or just commands which are not used by the driver ?
With my limited pmbus knowledge I am starting to figure out that the BMR456/457 can be operated with the generic pmbus driver. As far as I understand, all I would need to do is add a bmr456 and bmr457 to the pmbus_id struct of the pmbus.c source file. Is this ok? Or am I missing something?
The datasheets are a bit vague, but I think you are right - adding the chip names to the id structure in pmbus.c should be sufficient. You can give it a try by just instantiating the generic "pmbus" device. If that works, you are pretty much done. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
