Re: [PATCH 3/4] hwmon: (max6650) Drop error message after memory allocation failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Feb 2014 09:41:05 -0800, Guenter Roeck wrote:
> The core code already generates an error message.
> 
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  drivers/hwmon/max6650.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
> index badff94..74916e7 100644
> --- a/drivers/hwmon/max6650.c
> +++ b/drivers/hwmon/max6650.c
> @@ -656,10 +656,8 @@ static int max6650_probe(struct i2c_client *client,
>  
>  	data = devm_kzalloc(&client->dev, sizeof(struct max6650_data),
>  			    GFP_KERNEL);
> -	if (!data) {
> -		dev_err(&client->dev, "out of memory.\n");
> +	if (!data)
>  		return -ENOMEM;
> -	}
>  
>  	data->client = client;
>  	mutex_init(&data->update_lock);

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

-- 
Jean Delvare
Suse L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux