Re: [PATCH] hwmon: Avoid initializing the same field twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/03/2014 09:42 AM, Jean Delvare wrote:
All hwmon drivers allocate their data structure with some form of
kzalloc, so setting data fields to zero explicitly is a waste of time.

Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>

Forgot: Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

---
Guenter, this is likely to conflict with your current conversion work,
as most of these drivers have not been converted yet (lm63 is the
exception.) I thought splitting this patch per driver was a little
overkill but maybe this would be better for you? I think I'll split at
least pc87360 anyway as it's non-trivial. Let me know how you want to
proceed.

Also, yes, separating the pc87360 patch might make sense.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux