On 02/02/2014 12:21 PM, Jean Delvare wrote:
Hi Guenter,
On Mon, 20 Jan 2014 10:38:45 -0800, Guenter Roeck wrote:
We can create all sysfs groups in one call by using sysfs_create_groups
instead of using sysfs_create_group individually for each group.
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
---
This patch is purely to prepare for the next patch in the series.
Both could be merged, though I think it makes sense to keep it separate
to show the sequence of changes.
I'm fine with the changes and either way is fine with me. Just one note:
drivers/hwmon/lm63.c | 38 +++++++++++++++-----------------------
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index 438e612..b56cb9f 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
(...)
@@ -1105,10 +1106,12 @@ static void lm63_init_client(struct i2c_client *client)
static int lm63_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
+ struct device *dev = &client->dev;
I prefer when this kind of change is done separately, so it doesn't
distract me from the actual changes when reviewing a patch.
I know, I am lazy. But you are right. I'll do that as a separate patch in the next revision.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
