On Sun, 26 Jan 2014 20:21:00 -0800, Guenter Roeck wrote: > On 01/26/2014 03:08 PM, Guenter Roeck wrote: > > On Ubuntu systems with CONFIG_REGULATOR enabled, the lm90 driver fails to load > > with an error mesage such as > > > > i2c 1-0018: Driver lm90 requests probe deferral > > > > This is a result of commit 3e0f964f2ad (hwmon: (lm90) Add power control) > > which adds mandatory regulator support to the lm90 driver. On non-dt systems > > with CONFIG_REGULATOR enabled, this fails if regulators are not fully > > specified. This is the case on a standard PC system. > > > Mark appears to object to that idea, so maybe we should just just revert > 3e0f964f2ad until a more acceptable solution is found. Well, I object as well, so I'm happy to not apply it. I hate seeing IS_ENABLED() creep into driver code. Any issue like that should be handled as a Kconfig dependency or with a better API. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
