On 09/27/2013 08:34 PM, Mark Brown wrote: > On Fri, Sep 27, 2013 at 04:34:27PM +0200, Lars-Peter Clausen wrote: >> This patch adds a new spi_w8r16be() helper, which is similar to spi_w8r16() >> except that it converts the read data word from big endian to native endianness >> before returning it. The reason for introducing this new helper is that for SPI > > This actually feels like a bug in spi_w8r16() - I'd expect it to be > returning native endian in the first place since in SPI a word is by > default big endian so I'd expect this to have more of a register I/O > model. It certainly seems to match what almost all of the users are > doing. According to the documentation of spi_w8r16() it is a feature. * The number is returned in wire-order, which is at least sometimes * big-endian. There seem to be at least two users though which assume that the result is in native endianness drivers/hwmon/ads7871.c and drivers/mfd/stmpe-spi.c > > That said I'm not sure this is worth fixing in which case the new API > makes sense. Or converting the users to regmap I guess. > regmap is always my first choice, but the users are all devices having varying register sizes, so regmap is not working that nicely. - Lars _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
