Re: [PATCH 1/1] hwmon: (acpi_power_meter) Fix incorrect placement of __initdata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 27 Aug 2013 20:18:08 +0530, Sachin Kamat wrote:
> On 27 August 2013 19:40, Russell King - ARM Linux
> <linux@xxxxxxxxxxxxxxxx> wrote:
> > Yes, better not to change what's already there if it works fine.
> > However, as I mentioned in my previous email, it's probably better to
> > have a convention here for new code rather than having people stick
> > these markers in random places within the declaration and hit the "it
> > silently doesn't work" case.
> 
>  init.h header file mentions the following about the attribute placement:
> 
>  For initialized data:
> * You should insert __initdata between the variable name and equal
> * sign followed by value, e.g.:
> *
> * static int init_variable __initdata = 0;
> * static const char linux_logo[] __initconst = { 0x32, 0x36, ... };

Yes, sure, but who reads that?

Not me.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux