Re: [PATCH] hwmon: (emc6w201) Staticize enum 'subfeature'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jingoo,

On Mon, 05 Aug 2013 16:30:46 +0900, Jingoo Han wrote:
> The enum 'subfeature' is used only in this file.
> Fix the following sparse warning:
> 
> drivers/hwmon/emc6w201.c:52:26: warning: symbol 'subfeature' was not declared. Should it be static?
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
>  drivers/hwmon/emc6w201.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c
> index 936898f..2aa5bc3 100644
> --- a/drivers/hwmon/emc6w201.c
> +++ b/drivers/hwmon/emc6w201.c
> @@ -49,7 +49,7 @@ static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END };
>  #define EMC6W201_REG_TEMP_HIGH(nr)	(0x57 + (nr) * 2)
>  #define EMC6W201_REG_FAN_MIN(nr)	(0x62 + (nr) * 2)
>  
> -enum { input, min, max } subfeature;
> +static enum { input, min, max } subfeature;
>  
>  /*
>   * Per-device data

A better fixed has already been submitted by Guenter Roeck:

http://lists.lm-sensors.org/pipermail/lm-sensors/2013-August/039599.html

The variable is not needed at all.

Thanks anyway,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux