On 08/08/2013 05:23 AM, Guenter Roeck wrote: > On 08/08/2013 02:47 AM, Wei Ni wrote: ... >> I think get_regulator() will return error values, not only >> -EPROBE_DEFER, so we should set data->lm90_reg to NULL to handle other >> error values. >> > Matter of opinion if you want to check for IS_ERR or NULL later on. No, if regulator returns either: * Something valid * Someting IS_ERR() ... then everywhere has to check the value using IS_ERR(). If regulator returns either: * Something valid * Someting NULL ... then everywhere has to check the value against NULL. checking against both IS_ERR() and NULL shouldn't ever happen, and likewise IS_ERR_OR_NULL() is deprecated. _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
