Hi Guenter,
Guenter Roeck <linux@xxxxxxxxxxxx> writes:
> On Wed, Jun 19, 2013 at 09:34:34PM +0200, Arnaud Ebalard wrote:
>>
>> GMT G762/763 fan speed PWM controller is connected directly to a fan
>> and performs closed-loop or open-loop control of the fan speed. Two
>> modes - PWM or DC - are supported by the chip. Introduced driver
>> provides various knobs to control the operations of the chip (via
>> sysfs interface). Specific characteristics of the system can be passed
>> either using board init code or via DT. Documentation for both the
>> driver and DT bindings are also provided.
>>
>> Signed-off-by: Arnaud Ebalard <arno@xxxxxxxxxxxx>
>
> Couple of additional nitpicks plus a bug.
>
>> +static void g762_of_clock_disable(struct i2c_client *client)
>> +{
>> + struct g762_data *data = i2c_get_clientdata(client);
>> +
>> + if (data->clk)
>> + return;
>
> Guess this should be
> if (!data->clk)
> return;
>
> Small but significant difference ...
I am going to find me a hole to hide in. Thanks for catching
this. Resending a v8 after fixing it and the other points you
pointed.
Cheers,
a+
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
