Re: [PATCH] hwmon: (adm1021) Strengthen chip detection for LM84 and MAX1617

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 6 Jun 2013 09:55:12 -0700, Guenter Roeck wrote:
> On Thu, Jun 06, 2013 at 03:51:40PM +0200, Jean Delvare wrote:
> > Note that the LM84 also doesn't have registers at 0xFE and 0xFF, still
> > the detection function reads from these, apparently without trouble.
> 
> We don't really check if the reads return an error, though. 
> (...)
> Would it be acceptable to check if reading 0xfe and 0xff return an error ?
> That would help weeding out some chips (the JC42 chips on our board return
> an error when reading register 0x08, for example).

We should definitely check for error on all SMBus calls in the detect
function.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux