> > > On Wed, 5 Jun 2013 12:57:07 +0400, Alexander Shiyan wrote: > > > > This patch renames structures, variables and functions to indicate support > > > > for various MC13xxx chips. > > > > > > > > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx> > > > > --- > > > > drivers/hwmon/mc13783-adc.c | 135 +++++++++++++++++++++----------------------- > > > > 1 file changed, 63 insertions(+), 72 deletions(-) > > > > > > Nack. This change serves absolutely no purpose, all it's doing it make > > > everyone's life harder. Just don't do that, thanks. > > > > I do not understand stubbornness here. > > The driver works for different chips, it should be reflected in the code. > > Let's look at it from another angle. What problem are you trying to > solve? I see absolutely no problem with the current function and file > names. Almost all Linux kernel drivers support more chips than their > name says. > > On the other hand, changing all function names makes backporting fixes > harder, and changing Kconfig symbol names makes upgrading to the new > kernel version harder for everyone. > > So the cost of your proposal far outweighs the benefits. Well, let's leave the kconfig symbol as is. But about the rest, that mc13783_* symbols in the log (debug) will say a developer who does not know about mc13892 compatibility with mc13783? I still believe that this should be reflected. Thanks. --- _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
