On Tue, May 28, 2013 at 03:47:49PM +0200, Thierry Reding wrote: > On Tue, May 28, 2013 at 05:29:40AM -0700, Guenter Roeck wrote: > > On Tue, May 28, 2013 at 01:19:23PM +0200, Thierry Reding wrote: > > > On Tue, May 28, 2013 at 12:15:04PM +0200, Arnaud Ebalard wrote: > > > > Hi Arnd, > > > > > > > > Arnd Bergmann <arnd@xxxxxxxx> writes: > > > > > > > > > On Tuesday 28 May 2013 00:02:29 Arnaud Ebalard wrote: > > > > >> > > > > >> This series adds support for GMT G762/G763. This work is based on a > > > > >> basic version for 2.6.31 kernel developed Olivier Mouchet for LaCie > > > > >> NAS. Updates have been performed to run on recent kernels. Support has > > > > >> been completed and additional features added: ability to configure > > > > >> various characteristics from .dts file, better initialization, alarms > > > > >> and error reporting support, gear mode, polarity, fan pulse per > > > > >> revolution, fan startup voltage control. > > > > > > > > > > I wonder if this could be split into two separate drivers, one for > > > > > the pwm subsystem, and one for a hardware-independent fan controller > > > > > based on the pwm interfaces. > > > > > > > > To be honest, I wouldn't even know how to start in order to do that. > > > > Additionally, it would be worth the effort if other drivers could be > > > > easily refactored using this idea. I'll let hwmon people provide some > > > > feedback and try and comply with their directions (based on the cpu > > > > cycle I can spend on this). > > > > > > What Arnd proposes doesn't sounds like a very good idea. PWM-controlled > > > fans should be able to work just fine using a generic driver that uses > > > the PWM framework, similar to the PWM backlight and LED drivers. > > > > > Isn't that exactly what Arnd proposed ? > > Oh, right. I meant to say: "What Arnd proposes sounds like a very good > idea." =) Sorry for the confusion. > I looked into it, and frankly I don't know how to make it work either. The chip is dedicated to fan control and supports both linear and pwm mode. Both modes are controlled differently. The available configuration options are very fan control specific. While I agree that a generic fan control driver for pwm chips would be great, problem here is that this is not a generic pwm controller. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
