On Sat, 27 Apr 2013 16:03:31 +0200, Simon Guinot wrote: > On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote: > > + /* > > + * Set default configuration values before passing the structure > > + * to OF helpers to overload them using those provided by .dts > > + * file (if any). Final config is then commited. > > + */ > > + g762_config_init(&conf); > > + g762_config_of_overload(client, &conf); > > + err = g762_config_commit(client, &conf); > > + if (err) > > + goto out; > > One more comment... Sorry for the multiple replies :) > > I am not sure that applying a configuration anyway is a good idea. > I think it could be best to stick with the bootloader configuration if > no platform data nor device tree data are given. FWIW, the common policy for hwmon drivers is actually to not change the device configuration unless they really have to. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
