Re: [PATCH v5 03/12] hwmon: (nct6775) Add support for temperature sensors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 26, 2013 at 10:35:14AM -0800, Joe Perches wrote:
> On Tue, 2013-02-26 at 10:23 -0800, Guenter Roeck wrote:
> > diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
> []
> > +static const u16 NCT6779_REG_TEMP_CONFIG[11] = { 0x18, 0x152 };
> 
> Isn't 11 too magic a number?
> 
Yes; good catch.

It actually doesn't need a size in the first place, as long as it has
(at least) the same size as NCT677x_REG_TEMP. Must be a leftover from
an earlier version of the code.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux