Hi Jaromir, On Thu, 17 Jan 2013 10:12:41 -0500 (EST), Jaromir Capik wrote: > Hello guys. > > The device file /dev/port might be missing in some cases > and the sensors detection is terminated when the user > tries to detect sensors dependent on it's existence. > That's not correct -> it's not a reason for terminating > the detection. I admit that dying in this case is a little abrupt. That being said, without /dev/port, you won't be able to detect Super-I/O chips, ISA chips and I/O-based IPMI interfaces, which only leave you with I2C/SMBus-based, PCI-based and MSR-based sensors. Are there really systems out there without /dev/proc where any of these is present? I am not particularly interested in tweaking sensors-detect for theoretical-only cases. > The attached patch solves the issue, so that a warning > is displayed and the detection continues. This is a first step forward, but from a user-friendliness perspective I'd say it is insufficient. If /dev/port isn't there then you shouldn't even try to open it, even less try 4 times and display 4 times the same error message. Instead, you should check for /dev/port absence upfront, let the user know about that and the limitations it implies, and then plain skip all detection steps which you know have no chance of succeeding. > The patch can be applied on the current trunk version. > Please, check the patch and merge it if possible. I have applied it [1], with an additional STDERR for the error message destination. [1] http://www.lm-sensors.org/changeset/6116 -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
