Re: [PATCH v2] hwmon: (sht15) check GPIO directions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 15, 2013 at 01:33:06PM -0500, Vivien Didelot wrote:
> Without this patch, the SHT15 driver may fail silently with a
> non-bidirectional data line and/or an input-only clock line.
> 
> This patch checks the return value of gpio_direction_* function calls
> and returns the error code (if any) to the caller. If an error occurs in
> the read work function (work_funct_t), we wake the queue up directly
> without updating the data->state flag, to notice the waiter of the I/O
> error.
> 
> The patch also makes minor cleanups: s/error_ret/unlock for some labels
> and uses devm_gpio_request_one() for the clock line.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>

Applied to -next.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux