On Sat, 3 Nov 2012 09:29:44 -0700, Guenter Roeck wrote:
> Add support to detect and report AMDTSI temperature sensor types.
> Only enable PECI and AMDTSI sensor selection if the chip is configured
> for it.
>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> Applies on top of the previously submitted patches.
> Only tested with IT8728F and Intel CPU.
>
> v2: Add AMDTSI support to IT8728F.
>
> drivers/hwmon/it87.c | 68 +++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 62 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index 6a1410b..ab5a8c5 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> (...)
> @@ -2030,6 +2036,56 @@ static int __devinit it87_probe(struct platform_device *pdev)
> break;
> }
>
> + if (data->features & FEAT_TEMP_OLD_PECI) {
> + reg = it87_read_value(data, IT87_REG_VID);
> + switch ((reg >> 4) & 0x07) {
> + case 0x0:
> + default:
> + data->features &=
> + ~(FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI);
> + break;
> + case 0x3: /* PCH (IT8721F) */
> + if (data->features & FEAT_TEMP_PECI) {
> + data->features &= ~FEAT_TEMP_PECI;
> + data->ext_temp_type = 6;
> + } else {
> + data->features &= ~FEAT_TEMP_OLD_PECI;
> + }
> + break;
> + case 0x4: /* AMDTSI */
> + data->ext_temp_type = 5;
> + break;
> + case 0x5: /* SST slave */
> + case 0x6: /* PECI */
> + case 0x7: /* SST host */
> + if (data->features & FEAT_TEMP_PECI)
> + data->features &= ~FEAT_TEMP_OLD_PECI;
> + data->ext_temp_type = 6;
> + break;
> + }
> + } else if (data->features & FEAT_TEMP_PECI) {
> + reg = it87_read_value(data, IT87_REG_VID);
> + switch ((reg >> 4) & 0x03) {
> + case 0x0: /* disabled */
> + /* Check if AMDTSI is enabled */
> + if (reg & 0x40) {
> + reg = it87_read_value(data,
> + IT87_REG_AMDTSI_HSR);
> + if (reg & 0x40) {
> + data->ext_temp_type = 5;
I admit I don't quite get why ITE made these separate configuration
bits when all it brings is the possibility to select a non-working
combination...
I will also admit I'm kind of lost with the IT8728F. The datasheet
suggests that the PCH temperature can be retrieved but there is no
configuration bit to actually select it? Or if bit 6 of IT87_REG_VID
supposed to do exactly that? And if so, where does the reading go?
BTW maybe we should come up with a different name for register 0x0A for
newer chips, otherwise the code gets a little confusing. IT87_REG_IFSEL
maybe?
> + break;
> + }
> + }
> + data->features &= ~FEAT_TEMP_PECI;
> + break;
> + case 0x1: /* SST slave */
> + case 0x2: /* PECI */
> + case 0x3: /* SST host */
> + data->ext_temp_type = 6;
> + break;
> + }
> + }
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
