Re: [PATCH] hwmon: Drop needless includes of <linux/delay.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2 Oct 2012 11:23:09 -0700, Guenter Roeck wrote:
> On Tue, Oct 02, 2012 at 06:20:56PM +0200, Jean Delvare wrote:
> > These drivers use no sleep or delay functions so they don't need to
> > include <linux/delay.h>.
> > 
> > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> > Cc: Rudolf Marek <r.marek@xxxxxxxxxxxx>
> 
> Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> Related question: Some drivers use jiffies but don't include linux/jiffies.h.
> Should we add that ?

Yes we should, otherwise we are at the mercy of build errors in the
future whenever inter-header file inclusions change.

I'll take care of this second patch to avoid conflicts with this one.

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux