On Wed, 19 Sep 2012 11:30:51 -0700, Guenter Roeck wrote:
> The following build warning is seen with -Wextra.
>
> lm93.c: In function ‘store_fan_smart_tach’:
> lm93.c:1833:2: warning: comparison of unsigned expression >= 0 is always true
>
> Drop the unnecessary comparison.
>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/hwmon/lm93.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm93.c b/drivers/hwmon/lm93.c
> index bf94618..c3d4255 100644
> --- a/drivers/hwmon/lm93.c
> +++ b/drivers/hwmon/lm93.c
> @@ -1830,7 +1830,7 @@ static ssize_t store_fan_smart_tach(struct device *dev,
>
> mutex_lock(&data->update_lock);
> /* sanity test, ignore the write otherwise */
> - if (0 <= val && val <= 2) {
> + if (val <= 2) {
> /* can't enable if pwm freq is 22.5KHz */
> if (val) {
> u8 ctl4 = lm93_read_byte(client,
Good catch.
Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
