On Monday, September 17, 2012, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote:
>> Any better/other ideas ? Is the problem that we have to increase the wait time,
>> or is something else going on ?
>
> No, it makes sense now that I got the right number of zeroes. ;-)
>
> So, to be explicit, this is the patch I would like to go in. It is
> completely safe, back-portable, and a no-brainer. Parag, are you ok
> with being the author on this one?
>
I am OK with the proposed timeout as it works for me. I'll add an
Tested-by: Parag Warudkar <parag.lkml@xxxxxxxxx>
Thanks :)
Parag
> Thanks,
> Henrik
>
> From 868fc42edcb3a338ce0a0334e2dc50b01a7f6844 Mon Sep 17 00:00:00 2001
> From: Parag Warudkar <parag.lkml@xxxxxxxxx>
> Date: Mon, 17 Sep 2012 17:49:55 +0200
> Subject: [PATCH] applesmc: Bump max wait
>
> A heavy-load test on a MacBookPro6,1 is still showing a substantial
> amount of read errors. Increasing the maximum wait time to 128 ms
> resolves the issue.
>
> maybe-Signed-off-by: Parag Warudkar <parag.lkml@xxxxxxxxx>
> Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> ---
> drivers/hwmon/applesmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index 2827088..8f3f6f2 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
> @@ -53,10 +53,10 @@
>
> #define APPLESMC_MAX_DATA_LENGTH 32
>
> -/* wait up to 32 ms for a status change. */
> +/* wait up to 128 ms for a status change. */
> #define APPLESMC_MIN_WAIT 0x0010
> #define APPLESMC_RETRY_WAIT 0x0100
> -#define APPLESMC_MAX_WAIT 0x8000
> +#define APPLESMC_MAX_WAIT 0x20000
>
> #define APPLESMC_READ_CMD 0x10
> #define APPLESMC_WRITE_CMD 0x11
> --
> 1.7.12
>
>
_______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
