On Wed, Sep 12, 2012 at 10:24:41AM +0200, Jean Delvare wrote: > On Tue, 11 Sep 2012 09:34:17 -0700, Guenter Roeck wrote: > > The driver uses be16_to_cpu and cpu_to_be16 to convert data in SMBus word > > operations from chip to host byte order. However, the data passed from and to > > the SMBus word API functions is in host byte order, not in chip byte order. > > Conversion should therefore use swab16 instead of be16 to change the byte order. > > > > Replace driver internal word conversion functions with SMBus API functions to > > solve the problem. > > > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > --- > > Candidate for 3.6 and -stable. > > Agreed, down to 3.2 (when i2c_smbus_read/write_word_swapped were > introduced.) If anyone needs the fix for a kernel older than this, it > will have to be implemented differently. > Fortunately, that driver was only introduced in 3.5 (and I didn't realize the be16 problem when reviewing it ;). Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
