Re: [PATCH 4/4] hwmon: (ina2xx) Add support for INA220 and INA230

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

On Mon, 10 Sep 2012 21:09:26 -0700, Guenter Roeck wrote:
> INA220 is register compatible to INA219, and INA230 is register compatible to
> INA226, so all we need to do is to add name aliases for those two chips.
> 
> Cc: Lothar Felten <l-felten@xxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  Documentation/hwmon/ina2xx |   18 ++++++++++++++++++
>  drivers/hwmon/Kconfig      |    6 +++---
>  drivers/hwmon/ina2xx.c     |   10 ++++++++++
>  3 files changed, 31 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/hwmon/ina2xx b/Documentation/hwmon/ina2xx
> index f50a6cc..03444f9 100644
> --- a/Documentation/hwmon/ina2xx
> +++ b/Documentation/hwmon/ina2xx
> @@ -8,12 +8,24 @@ Supported chips:
>      Datasheet: Publicly available at the Texas Instruments website
>                 http://www.ti.com/
>  
> +  * Texas Instruments INA220
> +    Prefix: 'ina220'
> +    Addresses: I2C 0x40 - 0x4f
> +    Datasheet: Publicly available at the Texas Instruments website
> +               http://www.ti.com/
> +
>    * Texas Instruments INA226
>      Prefix: 'ina226'
>      Addresses: I2C 0x40 - 0x4f
>      Datasheet: Publicly available at the Texas Instruments website
>                 http://www.ti.com/
>  
> +  * Texas Instruments INA230
> +    Prefix: 'ina230'
> +    Addresses: I2C 0x40 - 0x4f
> +    Datasheet: Publicly available at the Texas Instruments website
> +               http://www.ti.com/
> +
>  Author: Lothar Felten <l-felten@xxxxxx>
>  
>  Description
> @@ -23,7 +35,13 @@ The INA219 is a high-side current shunt and power monitor with an I2C
>  interface. The INA219 monitors both shunt drop and supply voltage, with
>  programmable conversion times and filtering.
>  
> +The INA220 is a high or low side current shunt and power monitor with an I2C
> +interface. The INA220 monitors both shunt drop and supply voltage.
> +
>  The INA226 is a current shunt and power monitor with an I2C interface.
>  The INA226 monitors both a shunt voltage drop and bus supply voltage.
>  
> +The INA230 is a high or low side current shunt and power monitor with an I2C
> +interface. The INA230 monitors both a shunt voltage drop and bus supply voltage.
> +
>  The shunt value in micro-ohms can be set via platform data.
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 148903c..f8ee9b4 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1145,11 +1145,11 @@ config SENSORS_AMC6821
>  	  will be called amc6821.
>  
>  config SENSORS_INA2XX
> -	tristate "Texas Instruments INA219, INA226"
> +	tristate "Texas Instruments INA219 and compatibles"
>  	depends on I2C && EXPERIMENTAL
>  	help
> -	  If you say yes here you get support for INA219 and INA226 power
> -	  monitor chips.
> +	  If you say yes here you get support for INA219, INA220, INA226, and
> +	  INA230 power monitor chips.
>  
>  	  The INA2xx driver is configured for the default configuration of
>  	  the part as described in the datasheet.
> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
> index eb42e8b..5ca273a 100644
> --- a/drivers/hwmon/ina2xx.c
> +++ b/drivers/hwmon/ina2xx.c
> @@ -5,10 +5,18 @@
>   * Zero Drift Bi-Directional Current/Power Monitor with I2C Interface
>   * Datasheet: http://www.ti.com/product/ina219
>   *
> + * INA220:
> + * Bi-Directional Current/Power Monitor with I2C Interface
> + * Datasheet: http://www.ti.com/product/ina220
> + *
>   * INA226:
>   * Bi-Directional Current/Power Monitor with I2C Interface
>   * Datasheet: http://www.ti.com/product/ina226
>   *
> + * INA230:
> + * Bidirectional Current/Power Monitor with I2C Interface

It's spelled "Bi-Directional" everywhere else.

> + * Datasheet: http://www.ti.com/product/ina230
> + *
>   * Copyright (C) 2012 Lothar Felten <l-felten@xxxxxx>
>   * Thanks to Jan Volkering
>   *
> @@ -278,7 +286,9 @@ static int ina2xx_remove(struct i2c_client *client)
>  
>  static const struct i2c_device_id ina2xx_id[] = {
>  	{ "ina219", ina219 },
> +	{ "ina220", ina219 },
>  	{ "ina226", ina226 },
> +	{ "ina230", ina226 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, ina2xx_id);

I did not check the datasheets but I'll trust you on compatibility.

Reviewed-by: Jean Delvare <khali@xxxxxxxxxxxx>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux