On Fri, Aug 31, 2012 at 5:02 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > DIV_ROUND_CLOSEST returns a bad result for negative dividends: > DIV_ROUND_CLOSEST(-2, 2) = 0 > > Most of the time this does not matter. However, in the hardware monitoring > subsystem, DIV_ROUND_CLOSEST is sometimes used on integers which can be > negative (such as temperatures). This seems to cause 3 new warnings in my m68k builds of v3.6-rc5: drivers/hwmon/mcp3021.c:76: warning: comparison is always true due to limited range of data type drivers/ide/ide-cd.c:1158: warning: comparison is always true due to limited range of data type drivers/ide/ide-cd.c:1159: warning: comparison is always true due to limited range of data type $ m68k-linux-gnu-gcc -v Using built-in specs. Target: m68k-linux-gnu Configured with: ../src/configure -v --enable-languages=c,c++ --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/m68k-linux-gnu/include/c++/4.1.2 --program-suffix=-4.1 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --disable-libssp --disable-werror --enable-checking=release --program-prefix=m68k-linux-gnu- --includedir=/usr/m68k-linux-gnu/include --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=m68k-linux-gnu Thread model: posix gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors