Re: [patch] hwmon: (sch56xx-common) signedness bug in sch56xx_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 10, 2012 at 12:24:13PM +0300, Dan Carpenter wrote:
> "address" is used to store an unsigned short on success but a negative
> error code on failure.  It needs to be an int for the error handling to
> work.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Patch merged into the original patch which introduced the problem.

Thanks,
Guenter

> ---
> This is for linux-next.  The bug was introduced in 1645e4fc "hwmon:
> (sch56xx-common) Fix build warnings"
> 
> diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
> index 69abbf7..c93061f5 100644
> --- a/drivers/hwmon/sch56xx-common.c
> +++ b/drivers/hwmon/sch56xx-common.c
> @@ -594,7 +594,7 @@ exit_device_put:
>  
>  static int __init sch56xx_init(void)
>  {
> -	unsigned short address;
> +	int address;
>  	const char *name = NULL;
>  
>  	address = sch56xx_find(0x4e, &name);
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux