On Sun, Aug 05, 2012 at 09:43:44PM +0100, Anthony Olech wrote: > This is the HWMON component driver of the Dialog DA9058 PMIC. > This driver is just one component of the whole DA9058 PMIC driver. > It depends on the core DA9058 MFD driver. > > Signed-off-by: Anthony Olech <anthony.olech.opensource@xxxxxxxxxxx> > Signed-off-by: David Dajun Chen <david.chen@xxxxxxxxxxx> [ ... ] > +static SENSOR_DEVICE_ATTR(vbat_mV, S_IRUGO, da9058_read_vbat, NULL, 0); > +static SENSOR_DEVICE_ATTR(adc_mV, S_IRUGO, da9058_read_misc_channel, NULL, > + DA9058_ADCMAN_MUXSEL_ADCIN); > +static SENSOR_DEVICE_ATTR(vfpin_mV, S_IRUGO, da9058_read_vfpin, NULL, 0); > +static SENSOR_DEVICE_ATTR(vfpin_mode, S_IRUGO, da9058_vfpin_mode, NULL, 0); > +static SENSOR_DEVICE_ATTR(tbat_mV, S_IRUGO, da9058_read_tbat, NULL, 0); > +static SENSOR_DEVICE_ATTR(tjunc_in, S_IRUGO, da9058_read_tjunc, NULL, 0); > +static SENSOR_DEVICE_ATTR(adc_mode, S_IWUSR | S_IRUGO, da9058_get_adc_mode, > + da9058_set_adc_mode, 0); Please use standard sysfs attribute names for temperature and voltage attributes. For configuration (XXX_mode), please use devicetreee and/or platform data, not sysfs attributes. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
