On Thu, Jul 26, 2012 at 09:59:36PM +0200, Jean Delvare wrote: > Hi Guenter, > > On Thu, 26 Jul 2012 06:37:50 -0700, Guenter Roeck wrote: > > On Thu, Jul 26, 2012 at 02:57:45PM +0200, Jean Delvare wrote: > > > Restoring the configuration register on device removal has the side > > > effect of also resetting the hysteresis value. This is inconsistent as > > > the other limits are not reset, only hysteresis. So, following the > > > principle of least surprise, preserve the hysteresis value when > > > restoring the configuration register. > > > > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > > > Good catch. Applied. > > Doh, please drop it, the patch is buggy. I wrote | where I meant & and > this hard-codes the hysteresis to -6°C at driver removal if the config > register changed. I didn't notice during my testing because config > doesn't change for me. Sorry for the noise. > .... and I didn't notice it wither, and had to look at the code for a while to find it. Doh as well. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
