[PATCH]: i2c-tools/decode-dimms: fix cryptic error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

decode-dimms doesn't handle correctly the case where the eeprom module
is loaded, but not eeprom is actually found (most of the cases when no
bus i2c driver exist for the system):

| # decode-dimms version 5929 (2011-02-16 14:58:38 +0100)
| 
| Memory Serial Presence Detect Decoder
| By Philip Edelbrock, Christian Zuckschwerdt, Burkart Lingner,
| Jean Delvare, Trent Piepho and others
| Can't use string ("") as a HASH ref while "strict refs" in use at /usr/bin/decode-dimms line 178

This tends to be a cryptic error message, at least for the users. The
patch below fixes the issue by outputting an error message in that
case.

Regards,
Aurelien


Index: eeprom/decode-dimms
===================================================================
--- eeprom/decode-dimms	(révision 6060)
+++ eeprom/decode-dimms	(copie de travail)
@@ -1774,6 +1774,9 @@
 	} elsif (! -d '/sys/module/eeprom') {
 		print "No EEPROM found, are you sure the eeprom module is loaded?\n";
 		exit;
+	} else {
+		print "No EEPROM found, the kernel probably does not support your hardware.\n";
+		exit;
 	}
 }

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@xxxxxxxxxxx                 http://www.aurel32.net

Attachment: signature.asc
Description: Digital signature

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux