Re: GA-Z77X-UD3H with ITE IT8728F, modprobe it87 freezes system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 11 Jul 2012 11:31:24 -0700, Guenter Roeck wrote:
> On Wed, Jul 11, 2012 at 06:10:43PM +0200, Jean Delvare wrote:
> > The 0xb7 is from the very first version of the it87 driver by Christophe
> > Gauthron 11 years ago. I have no idea why bit 3 was explicitly cleared back
> > then.
>
> Oversight, maybe, or the bit name was confusing.
> 
> It doesn't make much sense to enable SMI interrupts while keeping global
> interrupts disabled. We may just have been lucky to never hit this problem.

I think so, yes.

> > > Replacing the 0x36 mask above with 0x3e might possibly solve the problem.
> > 
> > Indeed. I'm not too sure what to do about bit 5, BTW, it might be
> > self-clearing as bit 7.
>
> I'd keep it as-is. Not worth trying to solve a problem which may not exist.

Agreed. I'll push the fix to Linus ASAP.

Thanks Stevie for the quick test report!

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux