Hi, > code size reduction on x86_64 is about 15 kBytes for all drivers. With Ah, this is useful information. Being home in the embedded world, I only activate the drivers I need, and for that the gain is marginal if any. I can accept that saving 15kB for an all-module distro build is nice. > In addition to that, it does help preventing memory leaks, and it does > make the code a bit simpler. I definately agree for new drivers, but changing working code without a proper need is a risk. Especially, because converting to devm_* can cause subtle bugs when done without thought. I've been bitten by that in [1] (last paragraph) where input_free_device is not covered by devm, so one still has to free the IRQ manually, otherwise OOPS. [1] http://permalink.gmane.org/gmane.linux.kernel.input/24180 > So, overall I do think it is worth it. Maybe not if I only look at one > driver, but very much so if I look at the overall impact. As said, I am not NACKing :) Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
