On Sun, Jun 17, 2012 at 05:16:19PM +0200, Jean Delvare wrote:
> On Fri, 15 Jun 2012 08:24:04 -0700, Guenter Roeck wrote:
> > Convert to use devm_ functions to reduce code size and simplify the code.
> >
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > drivers/hwmon/w83781d.c | 46 ++++++++++++++++------------------------------
> > 1 file changed, 16 insertions(+), 30 deletions(-)
> >
> > diff --git a/drivers/hwmon/w83781d.c b/drivers/hwmon/w83781d.c
> > index a82f508..55422a0 100644
> > --- a/drivers/hwmon/w83781d.c
> > +++ b/drivers/hwmon/w83781d.c
> > (...)
> > @@ -1237,25 +1235,22 @@ w83781d_probe(struct i2c_client *client, const struct i2c_device_id *id)
> > /* Register sysfs hooks */
> > err = w83781d_create_files(dev, data->type, 0);
> > if (err)
> > - goto ERROR4;
> > + goto remove_files;
> >
> > data->hwmon_dev = hwmon_device_register(dev);
> > if (IS_ERR(data->hwmon_dev)) {
> > err = PTR_ERR(data->hwmon_dev);
> > - goto ERROR4;
> > + goto remove_files;
> > }
> >
> > return 0;
> >
> > -ERROR4:
> > +remove_files:
>
> For consistency with the isa code, you could name this label
> "exit_remove_files", and add a leading space.
>
Done.
> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
>
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
