On Sun, Jun 17, 2012 at 08:52:56AM +0200, Jean Delvare wrote:
> On Fri, 15 Jun 2012 08:23:56 -0700, Guenter Roeck wrote:
> > Convert to use devm_ functions to reduce code size and simplify the code.
> >
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > drivers/hwmon/thmc50.c | 15 +++++----------
> > 1 file changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/hwmon/thmc50.c b/drivers/hwmon/thmc50.c
> > index add9f01..2f78e3f 100644
> > --- a/drivers/hwmon/thmc50.c
> > +++ b/drivers/hwmon/thmc50.c
> > @@ -361,11 +361,11 @@ static int thmc50_probe(struct i2c_client *client,
> > struct thmc50_data *data;
> > int err;
> >
> > - data = kzalloc(sizeof(struct thmc50_data), GFP_KERNEL);
> > + data = devm_kzalloc(&client->dev, sizeof(struct thmc50_data),
> > + GFP_KERNEL);
> > if (!data) {
> > - pr_debug("thmc50: detect failed, kzalloc failed!\n");
> > - err = -ENOMEM;
> > - goto exit;
> > + pr_debug("thmc50: detect failed, devm_kzalloc failed!\n");
>
> This message is confusing, as we are in the probe function and not the
> detect function. Plus, dev_dbg() should be used instead or pr_debug.
>
> But actually I don't think we need any message here, the driver core
> will display a warning message whenever a probe fails (other than with
> -ENXIO or -ENODEV) so this one is redundant. Please drop it.
>
Done.
Thanks,
Guenter
> > + return -ENOMEM;
> > }
> > (...)
>
> Other than this:
>
> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
>
> --
> Jean Delvare
>
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
