Re: [PATCH 23/95] hwmon: (asc7621) Convert to use devm_ functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 15, 2012 at 9:23 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> Convert to use devm_ functions to reduce code size and simplify the code.
>
> Cc: George Joseph <george.joseph@xxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Acked-by: George Joseph <george.joseph@xxxxxxxxxxxxx>

Thanks Guenter!

> ---
>  drivers/hwmon/asc7621.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/asc7621.c b/drivers/hwmon/asc7621.c
> index 7caa242..b867aab7 100644
> --- a/drivers/hwmon/asc7621.c
> +++ b/drivers/hwmon/asc7621.c
> @@ -1109,7 +1109,8 @@ asc7621_probe(struct i2c_client *client, const
> struct i2c_device_id *id)
>        if (!i2c_check_functionality(client->adapter,
> I2C_FUNC_SMBUS_BYTE_DATA))
>                return -EIO;
>
> -       data = kzalloc(sizeof(struct asc7621_data), GFP_KERNEL);
> +       data = devm_kzalloc(&client->dev, sizeof(struct asc7621_data),
> +                           GFP_KERNEL);
>        if (data == NULL)
>                return -ENOMEM;
>
> @@ -1143,7 +1144,6 @@ exit_remove:
>                                   &(asc7621_params[i].sda.dev_attr));
>        }
>
> -       kfree(data);
>        return err;
>  }
>
> @@ -1192,7 +1192,6 @@ static int asc7621_remove(struct i2c_client *client)
>                                   &(asc7621_params[i].sda.dev_attr));
>        }
>
> -       kfree(data);
>        return 0;
>  }
>
> --
> 1.7.9.7
>

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux