Re: [PATCH 46/95] hwmon: (lm78) Convert to use devm_ functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 15 Jun 2012 08:23:27 -0700, Guenter Roeck wrote:
> Convert to use devm_ functions to reduce code size and simplify the code.
> 
> Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  drivers/hwmon/lm78.c |   38 ++++++++++++--------------------------
>  1 file changed, 12 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
> index f6bc414..1eacac9 100644
> --- a/drivers/hwmon/lm78.c
> +++ b/drivers/hwmon/lm78.c
> (...)
> @@ -885,28 +880,19 @@ static int __devinit lm78_isa_probe(struct platform_device *pdev)
>  
>  	return 0;
>  
> - exit_remove_files:
> +exit_remove_files:

The space before the label wasn't a mistake, it's there on purpose. The
goal is to let diff -p display function names rather than labels. I
seemed to recall that Documentation/CodingStyle mentioned that, but I
can't find it again. You'll notice though that checkpatch doesn't
complain about it, not even in strict mode.

Other than this:

Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux