On Tue, 15 May 2012 12:51:08 -0700, Guenter Roeck wrote: > On Tue, 2012-05-15 at 14:21 -0400, Jean Delvare wrote: > > What about FAN3_TAC? As I read the datasheet, it is also "freed" if > > UART6 is moved to pins 100-106. So I suspect we don't want to check for > > uart6 at all for the IT8783F. > > > The data sheet says, with Register 0x27/Bit 0: > > Function Selection of Pin 93 (FSP) > 0: VIN5/FAN_TAC3/SIN6 > If bit 2 of index 2Ch is 1, FAN_TAC3/SIN6 input is enabled; otherwise > select VIN5 input. > 1: GP30 > > Assuming the above is correct, I think I'll rename "uart6" to "fan3" and > use > > fan3 = reg2C & (1 << 2); > ... > /* Check if fan3 is there or not */ > if ((reg27 & (1 << 0)) || !fan3) > sio_data->skip_fan |= (1 << 2); > ... > if ((reg27 & (1 << 0)) || fan3) > sio_data->skip_in |= (1 << 5); /* No VIN5 */ > > Does that make sense ? That's what the datasheet says, at least. I find it weird that enabling UART6 has an effect on VIN5 vs. FAN3_TAC, especially when UART6 pins can be remapped to a completely different location, but maybe this is really how the chip works. I think I wouldn't introduce variable fan3, as it is kind of a misnomer, and a proper name would be overly long. But this is an implementation detail. Björn, what is your design using pin 93 for? -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
