Re: [PATCH] hwmon: (coretemp) Increase CPU core limit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-05-01 at 11:58 -0400, Jean Delvare wrote:
> On Tue, 1 May 2012 08:19:53 -0700, Guenter Roeck wrote:
> > CPU core ID is used to index the core_data[] array. The core ID is, however, not
> > sequential; 10-core CPUS can have a core ID as high as 25. Increase the limit to
> > 32 to be able to deal with current CPUs.
> > 
> > Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx # 3.0+
> > ---
> >  drivers/hwmon/coretemp.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index 54a70fe..b9d5123 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
> >  MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
> >  
> >  #define BASE_SYSFS_ATTR_NO	2	/* Sysfs Base attr no for coretemp */
> > -#define NUM_REAL_CORES		16	/* Number of Real cores per cpu */
> > +#define NUM_REAL_CORES		32	/* Number of Real cores per cpu */
> >  #define CORETEMP_NAME_LENGTH	17	/* String Length of attrs */
> >  #define MAX_CORE_ATTRS		4	/* Maximum no of basic attrs */
> >  #define TOTAL_ATTRS		(MAX_CORE_ATTRS + 1)
> 
> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
> 
> Looking forward, it would be great if we could get rid of this
> arbitrary limit.
> 
Agreed. I thought about dynamic allocation and a small hash table to
access it. If/when I have time ... or someone else, maybe.

Guenter




_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux