Hi Guenter, On Mon, 12 Mar 2012 08:43:24 -0700, Guenter Roeck wrote: > NCT6775F and NCT6776F have their own set of registers for FAN_STOP_TIME. The > correct registers were used to read FAN_STOP_TIME, but writes used the wrong > registers. Fix it. > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > drivers/hwmon/w83627ehf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c > index 57a31a0..378142c 100644 > --- a/drivers/hwmon/w83627ehf.c > +++ b/drivers/hwmon/w83627ehf.c > @@ -1622,7 +1622,7 @@ store_##reg(struct device *dev, struct device_attribute *attr, \ > val = step_time_to_reg(val, data->pwm_mode[nr]); \ > mutex_lock(&data->update_lock); \ > data->reg[nr] = val; \ > - w83627ehf_write_value(data, W83627EHF_REG_##REG[nr], val); \ > + w83627ehf_write_value(data, data->REG_##REG[nr], val); \ > mutex_unlock(&data->update_lock); \ > return count; \ > } \ Good catch. Acked-by: Jean Delvare <khali@xxxxxxxxxxxx> This would seem like a candidate for stable, hm? As a side note, someone's got to explain to me why these functions are macro-generated when the macro is called only once. It would be a good idea to unfold that code to make it easier to read. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
