Re: [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/21/2012 12:58 AM, Guenter Roeck wrote:
> On Mon, Feb 20, 2012 at 05:53:16PM -0500, Roland Stigge wrote:
>> On 20/02/12 22:58, Chris wrote:
>>> Patch to fix PPR register initialization to set both channels
>>> Signed-off-by: Chris D Schimp <silverchris <at> gmail.com>
>>
>> Looks good.
>>
>> Acked-by: Roland Stigge <stigge@xxxxxxxxx>
>>
> So << 6 instead of << 5 is ok ?

Yes, see datasheet, Register Map, Reg. 24h+25h. It's the upper 2 bits of
the 8 bit register for the 2 bits of PPR.

Further, I agree that the patch style should be improved before submitting.

Thanks,

Roland

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux