On Fri, 2012-01-27 at 11:53 -0500, Jean Delvare wrote: > Hi Uwe, > > On Tue, 27 Sep 2011 23:16:09 +0200, Uwe Kleine-König wrote: > > Based on a patch by David Jander that mostly did s/mc13783/mc13xxx/ > > > > Cc: David Jander <david.jander@xxxxxxxxxxx> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > changes since (implicit) v1: > > - update documentation > > - undo driver renaming > > - fix show_name callback (not 100% sure it is correct to give a different name > > on mc13892. I think name contains the prefix documented in > > Documentation/hwmon/mc13783-adc?!) > > - implement some differences between mc13783 and mc13892 that I noticed when > > updating the docs > > - different scaling for bp channel > > - no general purpose channels 8-15 on mc13892 > > - take over authorship as the patch got much more complicated now compared to > > David's original. > > > > Documentation/hwmon/mc13783-adc | 48 ++++++++++++---- > > drivers/hwmon/Kconfig | 6 +- > > drivers/hwmon/mc13783-adc.c | 113 +++++++++++++++++++++++++++++---------- > > 3 files changed, 123 insertions(+), 44 deletions(-) > > As merging this got stuck after Guenter's last review (thanks Guenter, > BTW) I am picking up from there and hopefully we can get this upstream. > Here I go with my review, mostly minor things: > I have been asked about adding support for ADC channels 0, 1, 3, 4, as well as the non-GP usage of channels 5 to 7. Does anyone happen to know/recall why those are not supported in the current driver ? Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
