On Mon, 2012-01-23 at 12:36 -0500, Jean Delvare wrote:
> Hi Guenter,
>
> On Thu, 19 Jan 2012 15:55:35 -0800, Guenter Roeck wrote:
> > Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > drivers/hwmon/lm90.c | 64 +++++++++++++++++++++++++++++--------------------
> > 1 files changed, 38 insertions(+), 26 deletions(-)
> >
> > diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
> > index d2dd5f9..dc11937 100644
> > --- a/drivers/hwmon/lm90.c
> > +++ b/drivers/hwmon/lm90.c
> > @@ -307,23 +307,27 @@ struct lm90_data {
> > u8 reg_local_ext; /* local extension register offset */
> >
> > /* registers values */
> > - s8 temp8[8]; /* 0: local low limit
> > - 1: local high limit
> > - 2: local critical limit
> > - 3: remote critical limit
> > - 4: local emergency limit (max6659 and max6695/96)
> > - 5: remote emergency limit (max6659 and max6695/96)
> > - 6: remote 2 critical limit (max6695/96 only)
> > - 7: remote 2 emergency limit (max6695/96 only) */
> > - s16 temp11[8]; /* 0: remote input
> > - 1: remote low limit
> > - 2: remote high limit
> > - 3: remote offset (except max6646, max6657/58/59,
> > - and max6695/96)
> > - 4: local input
> > - 5: remote 2 input (max6695/96 only)
> > - 6: remote 2 low limit (max6695/96 only)
> > - 7: remote 2 high limit (ma6695/96 only) */
> > + s8 temp8[8]; /*
> > + * 0: local low limit
> > + * 1: local high limit
>
> I tend to find it less readable this way, because of the shift between
> the declaration and the explanation. I'm wondering if checkpatch would
> complain if we cheat a bit in this case and do:
>
> s8 temp8[8]; /* 0: local low limit
> * 1: local high limit
>
> etc. Would you consider it acceptable?
>
ok with me, and checkpatch doesn't complain.
> > + * 2: local critical limit
> > + * 3: remote critical limit
> > + * 4: local emergency limit (max6659 and max6695/96)
> > + * 5: remote emergency limit (max6659 and max6695/96)
> > + * 6: remote 2 critical limit (max6695/96 only)
> > + * 7: remote 2 emergency limit (max6695/96 only)
> > + */
> > + s16 temp11[8]; /*
> > + * 0: remote input
> > + * 1: remote low limit
> > + * 2: remote high limit
> > + * 3: remote offset (except max6646, max6657/58/59,
> > + * and max6695/96)
>
> Original was better aligned.
>
fixed.
> > + * 4: local input
> > + * 5: remote 2 input (max6695/96 only)
> > + * 6: remote 2 low limit (max6695/96 only)
> > + * 7: remote 2 high limit (ma6695/96 only)
>
> There's an "x" missing here, was already the case originally but let's
> fix it.
>
fixed. I'll send an updated patch in a minute.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
