Re: [PATCH 12/39] hwmon: (f71805f) Fix checkpatch issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 16 Jan 2012 00:49:14 -0800, Guenter Roeck wrote:
> Fixed:
> ERROR: code indent should use tabs where possible
> ERROR: do not use assignment in if condition
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: need consistent spacing around '|' (ctx:VxW)
> WARNING: simple_strtol is obsolete, use kstrtol instead
> WARNING: simple_strtoul is obsolete, use kstrtoul instead
> WARNING: static const char * array should probably be static const char * const
> 
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  drivers/hwmon/f71805f.c |  163 ++++++++++++++++++++++++++++++++++-------------
>  1 files changed, 118 insertions(+), 45 deletions(-)
>
> diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c
> index 92f9497..859b203 100644
> --- a/drivers/hwmon/f71805f.c
> +++ b/drivers/hwmon/f71805f.c
> (...)

Looks OK, tested without problems.

Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>

I noticed an unrelated bug during my testing, I'll investigate it and
send a fix.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux