On Thu, 2012-01-19 at 11:31 -0500, Jean Delvare wrote: > On Thu, 19 Jan 2012 08:23:50 -0800, Guenter Roeck wrote: > > Hi Jean, > > > > On Thu, 2012-01-19 at 08:54 -0500, Jean Delvare wrote: > > > On Mon, 16 Jan 2012 00:49:36 -0800, Guenter Roeck wrote: > > > > diff --git a/drivers/hwmon/w83781d.c b/drivers/hwmon/w83781d.c > > > > index 65b685e..816cc16 100644 > > > > --- a/drivers/hwmon/w83781d.c > > > > +++ b/drivers/hwmon/w83781d.c > > > > @@ -1,9 +1,9 @@ > > > > /* > > > > w83781d.c - Part of lm_sensors, Linux kernel modules for hardware > > > > - monitoring > > > > + monitoring > > > > Copyright (c) 1998 - 2001 Frodo Looijaard <frodol@xxxxxx>, > > > > - Philip Edelbrock <phil@xxxxxxxxxxxxx>, > > > > - and Mark Studebaker <mdsxyz123@xxxxxxxxx> > > > > + Philip Edelbrock <phil@xxxxxxxxxxxxx>, > > > > + and Mark Studebaker <mdsxyz123@xxxxxxxxx> > > > > Copyright (c) 2007 - 2008 Jean Delvare <khali@xxxxxxxxxxxx> > > > > > > > > This program is free software; you can redistribute it and/or modify > > > > > > The actual reason why checkpatch complains here is because it thinks > > > this is code, not a comment. The proper fix would be to use proper > > > comment style. > > > > Good point. I did wonder about that. I thought it would be a lot of work > > to fix the comments. so I didn't even try. I'll see if I can come up > > with a script to automate it. If so, I'll submit a separate series of > > patches to address it for all drivers. > > I'd have a less ambitious approach and simply fix the comment style if > you were going to update the comment in question already. But up to you. > Turned out the script was easy to write. Only problem with the result is that it modified 82 files (out of 117). Only remaining question is if I should go forward with it. Thoughts ? Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
