On Fri, 13 Jan 2012 07:13:36 -0800, Guenter Roeck wrote: > On Fri, Jan 13, 2012 at 09:51:00AM -0500, Jean Delvare wrote: > > Add support for fan[1-*]_max, fan[1-*]_min_alarm and fan[1-*]_max_alarm > > attributes. These are defined in the standard sysfs interface for quite > > some time, and at least three drivers (max6650, lm63 and applesmc) > > implement them so we should support them. > > --- > > doc/libsensors-API.txt | 3 +++ > > lib/sensors.h | 3 +++ > > lib/sysfs.c | 3 +++ > > prog/sensors/chips.c | 38 +++++++++++++++++++++++++------------- > > 4 files changed, 34 insertions(+), 13 deletions(-) > > > Looks good. > > Maybe I should try to re-do that using the table based generic code. Wonder why I didn't earlier. To be honest, I considered it first, and then saw that it was broken, so we should fix it first. But lacking the time and energy to do that today, I took the short path to where I needed to go. The problem I see in the generic code is with power limits, "interval" is considered a limit and will thus be printed with unit "W" instead of "s". Likewise fan[1-*]_div would show up with unit RPM which is no good. Apparently we need a way to force unit (or lack thereof) on a per-limit basis. Maybe we can leverage the work done for temperatures (°C vs. °F), but I'm not sure. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
