On Thu, 12 Jan 2012 14:14:45 -0800, Guenter Roeck wrote: > On Thu, 2012-01-12 at 16:51 -0500, Jean Delvare wrote: > > It's questionable whether you want 3 or rather 1 for TruTherm beta > > compensation mode. While Documentation/hwmon/sysfs-interface says 1 is > > PII/Celeron Diode, I think this is an historical glitch and what it > > really means is "CPU embedded diode". It might be the right time to fix > > that. BTW "sensors" says just "diode" for type 1, with no reference to > > PII/Celeron. > > > Ok with me. Should we change the documentation as well (separate > patch) ? I think so, yes. Either you do it, or I'll do if you prefer. > > (...) > > It might make sense to return the error value if the write fails? > > > We could do that, but it should be a separate patch to add error > handling to the entire driver. Good point, I agree. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
