Re: [PATCH 2/5] hwmon: (lm63) Add support for LM96163

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon,  9 Jan 2012 19:42:00 -0800, Guenter Roeck wrote:
> From: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> 
> LM96163 is an enhanced version of LM63 with improved PWM resolution. Add chip
> detection code as well as support for improved PWM resolution if the chip is
> configured to use it.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  Documentation/hwmon/lm63 |    8 ++++++++
>  drivers/hwmon/Kconfig    |    4 ++--
>  drivers/hwmon/lm63.c     |   41 ++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 46 insertions(+), 7 deletions(-)
> (...)

I already have reviewed that one. You have a minor bug in your copy,
BTW, which is fixed in mine:

> +			dev_warn(&client->dev,
> +				 "Unsigned format for High and Crit setpoints enabled but not supported by driver");

Missing \n at the end of this string.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux