Re: [PATCH] drivers/hwmon/lm80.c: fixed checkpatch warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter

Thanks for the feedback.
I'll give it another stab tomorrow or so.

On kstrtol:

2012/1/3 Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>


>  { \
>         int nr = to_sensor_dev_attr(attr)->index; \
>         struct i2c_client *client = to_i2c_client(dev); \
>         struct lm80_data *data = "" \
> -       long val = simple_strtol(buf, NULL, 10); \
> - \
> +       long val = kstrtol(buf, NULL, 10); \
> +\

Does this compile w/o error or warning ?
Parameters change from simple_strtol() to kstrtol(), so this won't work,
and I would think it should result at least in a compile warning.

Hm. Don't recall seeing a warning, guess I overlooked it.

Anyway, the mistake I made was that just before I fixed the lm75 file, but there the call was to strict_strtoul. Coming here I overlooked things and mixed up strict_strtol and simple_strtol.
Apologies for the inconvenience.

I'll change (but probably will make it a separate patch then).

Best regards, Frans



_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux